IBX-7999: Checkbox and ThreeStateCheckbox #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces checkbox component implementations for the Ibexa design system, including both standard checkbox and three-state checkbox components with corresponding TypeScript functionality.
- Adds PHP Twig components for Checkbox and ThreeStateCheckbox with proper inheritance structure
- Implements TypeScript classes for checkbox behavior with indeterminate state support
- Creates Twig templates for rendering checkbox HTML markup
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib/Twig/Components/inputs/AbstractCheckbox.php | Base abstract class providing common checkbox properties and validation |
| src/lib/Twig/Components/inputs/Checkbox.php | Standard checkbox component extending AbstractCheckbox |
| src/lib/Twig/Components/inputs/ThreeStateCheckbox.php | Three-state checkbox component with indeterminate property |
| src/bundle/Resources/views/themes/standard/design_system/components/inputs/Checkbox.html.twig | Twig template for standard checkbox rendering |
| src/bundle/Resources/views/themes/standard/design_system/components/inputs/ThreeStateCheckbox.html.twig | Twig template for three-state checkbox with indeterminate styling |
| src/bundle/Resources/public/ts/shared/BaseCheckbox.ts | Base TypeScript class for checkbox components |
| src/bundle/Resources/public/ts/components/inputs/Checkbox.ts | Standard checkbox TypeScript implementation |
| src/bundle/Resources/public/ts/components/inputs/ThreeStateCheckbox.ts | Three-state checkbox with indeterminate state handling |
| src/bundle/Resources/public/ts/components/inputs/InputText.ts | Fixed class name typo from InpuText to InputText |
| src/bundle/Resources/public/ts/init_components.ts | Added initialization for both checkbox components |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| @@ -1,6 +1,6 @@ | |||
| import Base from '../../shared/Base'; | |||
|
|
|||
| export default class InpuText extends Base { | |||
| export default class InputText extends Base { | |||
There was a problem hiding this comment.
The class name 'InpuText' was misspelled and has been correctly fixed to 'InputText'.
Copilot uses AI. Check for mistakes.
albozek
approved these changes
Aug 25, 2025
OstafinL
approved these changes
Aug 26, 2025
dew326
approved these changes
Aug 26, 2025
tischsoic
approved these changes
Aug 26, 2025
mikadamczyk
reviewed
Aug 26, 2025
src/bundle/Resources/views/themes/standard/design_system/components/inputs/Checkbox.html.twig
Show resolved
Hide resolved
src/bundle/Resources/views/themes/standard/design_system/components/inputs/Checkbox.html.twig
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
For QA:
Documentation: